sstent/silverbullet-icalendar
1
0
Fork 0
forked from GitHubMirrors/silverbullet-icalendar
Code Pull Requests Actions Packages Releases Activity

conductor(plan): Update plan based on investigation of logs

Browse Source
This commit is contained in:
sstent
2026-02-20 11:30:58 -08:00
parent 0b1ef83999
commit 028ae7d9f9
1 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
conductor/tracks/fix_recurring_visibility_20260219/plan.md
View File

@@ -1,17 +1,21 @@
# Implementation Plan - Fix Recurring Meetings Visibility
## Phase 1: Investigation & Reproduction
- [ ] Task: Create validation test case
- [ ] Add a test in `icalendar_test.ts` with a valid weekly recurring event starting in the past.
- [ ] Assert that it returns multiple occurrences within the 30-day window.
- [ ] Run the test to see if it fails (confirming the bug).
## Phase 1: Investigation & Reproduction [checkpoint: pending]
- [x] Task: Create validation test case
- [x] Add a test in `icalendar_test.ts` with a valid weekly recurring event starting in the past.
- [x] Assert that it returns multiple occurrences within the 30-day window.
- [x] Run the test to see if it fails (confirming the bug).
- [ ] Task: Investigate Object RRULE
- [ ] The logs show `Invalid rrule type (object)`. This means `ts-ics` is parsing RRULE into an object, not a string.
- [ ] Create a test case where `rrule` is an object (mocking `ts-ics` output).
- [ ] Verify that it returns only 1 event (the bug).
- [ ] Task: Conductor - User Manual Verification 'Investigation & Reproduction' (Protocol in workflow.md)
## Phase 2: Fix Logic
- [ ] Task: Debug and Fix `expandRecurrences`
- [ ] Analyze the date window filtering logic (`filterStart`, `windowEnd`).
- [ ] Adjust logic if events are being filtered out incorrectly.
- [ ] Run the validation test case to confirm the fix.
- [ ] Task: Support Object RRULE in `expandRecurrences`
- [ ] Modify `expandRecurrences` to handle `rrule` as an object.
- [ ] It likely needs to be converted back to a string or used directly if `rrule` library supports it.
- [ ] Run the new test case to confirm the fix.
- [ ] Task: Conductor - User Manual Verification 'Fix Logic' (Protocol in workflow.md)
## Phase 3: Cleanup & Verification