conductor(checkpoint): Checkpoint end of Phase 2 - Aggregator Refactor
This commit is contained in:
@@ -1,11 +1,12 @@
|
||||
import pytest
|
||||
from unittest.mock import patch, MagicMock
|
||||
import consul_client
|
||||
import requests
|
||||
|
||||
@patch("requests.get")
|
||||
def test_get_cluster_services(mock_get):
|
||||
"""Test fetching healthy services from Consul."""
|
||||
# Mock responses for navidrome and replica-navidrome
|
||||
# Mock responses for navidrome
|
||||
mock_navidrome = [
|
||||
{
|
||||
"Node": {"Node": "node1", "Address": "192.168.1.101"},
|
||||
@@ -13,55 +14,19 @@ def test_get_cluster_services(mock_get):
|
||||
"Checks": [{"Status": "passing"}]
|
||||
}
|
||||
]
|
||||
mock_replicas = [
|
||||
{
|
||||
"Node": {"Node": "node2", "Address": "192.168.1.102"},
|
||||
"Service": {"Service": "replica-navidrome", "Port": 4533, "ID": "replica-1"},
|
||||
"Checks": [{"Status": "passing"}]
|
||||
},
|
||||
{
|
||||
"Node": {"Node": "node3", "Address": "192.168.1.103"},
|
||||
"Service": {"Service": "replica-navidrome", "Port": 4533, "ID": "replica-2"},
|
||||
"Checks": [{"Status": "critical"}] # One failing check
|
||||
}
|
||||
]
|
||||
|
||||
def side_effect(url, params=None, timeout=None):
|
||||
if "health/service/navidrome" in url:
|
||||
m = MagicMock()
|
||||
m.json.return_value = mock_navidrome
|
||||
m.raise_for_status.return_value = None
|
||||
return m
|
||||
elif "health/service/replica-navidrome" in url:
|
||||
m = MagicMock()
|
||||
m.json.return_value = mock_replicas
|
||||
m.raise_for_status.return_value = None
|
||||
return m
|
||||
return MagicMock()
|
||||
m = MagicMock()
|
||||
m.json.return_value = mock_navidrome
|
||||
m.raise_for_status.return_value = None
|
||||
mock_get.return_value = m
|
||||
|
||||
mock_get.side_effect = side_effect
|
||||
|
||||
consul_url = "http://consul:8500"
|
||||
services = consul_client.get_cluster_services(consul_url)
|
||||
|
||||
# Should find 3 nodes total (node1 primary, node2 healthy replica, node3 critical replica)
|
||||
assert len(services) == 3
|
||||
|
||||
# Check node1 (primary)
|
||||
node1 = next(s for s in services if s["node"] == "node1")
|
||||
assert node1["role"] == "primary"
|
||||
assert node1["status"] == "passing"
|
||||
assert node1["address"] == "192.168.1.101"
|
||||
|
||||
# Check node2 (healthy replica)
|
||||
node2 = next(s for s in services if s["node"] == "node2")
|
||||
assert node2["role"] == "replica"
|
||||
assert node2["status"] == "passing"
|
||||
|
||||
# Check node3 (critical replica)
|
||||
node3 = next(s for s in services if s["node"] == "node3")
|
||||
assert node3["role"] == "replica"
|
||||
assert node3["status"] == "critical"
|
||||
|
||||
# Should find 1 node (primary)
|
||||
assert len(services) == 1
|
||||
assert services[0]["node"] == "node1"
|
||||
assert services[0]["status"] == "passing"
|
||||
|
||||
@patch("requests.get")
|
||||
def test_get_cluster_services_with_errors(mock_get):
|
||||
@@ -71,38 +36,18 @@ def test_get_cluster_services_with_errors(mock_get):
|
||||
"Node": {"Node": "node1", "Address": "192.168.1.101"},
|
||||
"Service": {"Service": "navidrome", "Port": 4533, "ID": "navidrome-1"},
|
||||
"Checks": [
|
||||
{"Status": "passing", "Output": "HTTP GET http://192.168.1.101:4533/app: 200 OK"}
|
||||
]
|
||||
}
|
||||
]
|
||||
mock_replicas = [
|
||||
{
|
||||
"Node": {"Node": "node3", "Address": "192.168.1.103"},
|
||||
"Service": {"Service": "replica-navidrome", "Port": 4533, "ID": "replica-2"},
|
||||
"Checks": [
|
||||
{"Status": "critical", "Output": "HTTP GET http://192.168.1.103:4533/app: 500 Internal Server Error"}
|
||||
{"Status": "critical", "Output": "HTTP GET http://192.168.1.101:4533/app: 500 Internal Server Error"}
|
||||
]
|
||||
}
|
||||
]
|
||||
|
||||
def side_effect(url, params=None, timeout=None):
|
||||
if "health/service/navidrome" in url:
|
||||
m = MagicMock()
|
||||
m.json.return_value = mock_navidrome
|
||||
m.raise_for_status.return_value = None
|
||||
return m
|
||||
elif "health/service/replica-navidrome" in url:
|
||||
m = MagicMock()
|
||||
m.json.return_value = mock_replicas
|
||||
m.raise_for_status.return_value = None
|
||||
return m
|
||||
return MagicMock()
|
||||
m = MagicMock()
|
||||
m.json.return_value = mock_navidrome
|
||||
m.raise_for_status.return_value = None
|
||||
mock_get.return_value = m
|
||||
|
||||
mock_get.side_effect = side_effect
|
||||
|
||||
services = consul_client.get_cluster_services("http://consul:8500")
|
||||
|
||||
node3 = next(s for s in services if s["node"] == "node3")
|
||||
assert node3["status"] == "critical"
|
||||
assert "500 Internal Server Error" in node3["check_output"]
|
||||
|
||||
node1 = next(s for s in services if s["node"] == "node1")
|
||||
assert node1["status"] == "critical"
|
||||
assert "500 Internal Server Error" in node1["check_output"]
|
||||
Reference in New Issue
Block a user