From d3c567a07c8dde32c814814d7fd4a3bd551bbe4d Mon Sep 17 00:00:00 2001
From: sstent <stuart.stent@gmail.com>
Date: Fri, 8 Aug 2025 12:55:20 -0700
Subject: [PATCH] python v1 - working list, download fixed

---
 garminsync/garmin.py | 95 ++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 88 insertions(+), 7 deletions(-)

diff --git a/garminsync/garmin.py b/garminsync/garmin.py
index ef15c80..f02f07c 100644
--- a/garminsync/garmin.py
+++ b/garminsync/garmin.py
@@ -32,11 +32,92 @@ class GarminClient:
         if not self.client:
             self.authenticate()
             
-        fit_data = self.client.download_activity(activity_id, dl_fmt='fit')
-        time.sleep(2)  # Rate limiting
-        return fit_data
+        print(f"Attempting to download activity {activity_id}")
+        
+        # Try multiple methods to download FIT file
+        methods_to_try = [
+            # Method 1: No format parameter (most likely to work)
+            lambda: self.client.download_activity(activity_id),
+            
+            # Method 2: Use 'fmt' instead of 'dl_fmt'
+            lambda: self.client.download_activity(activity_id, fmt='fit'),
+            
+            # Method 3: Use 'format' parameter
+            lambda: self.client.download_activity(activity_id, format='fit'),
+            
+            # Method 4: Try original parameter name with different values
+            lambda: self.client.download_activity(activity_id, dl_fmt='FIT'),
+            lambda: self.client.download_activity(activity_id, dl_fmt='tcx'),  # Fallback format
+        ]
+        
+        last_exception = None
+        
+        for i, method in enumerate(methods_to_try, 1):
+            try:
+                print(f"Trying download method {i}...")
+                fit_data = method()
+                
+                if fit_data:
+                    print(f"Successfully downloaded {len(fit_data)} bytes using method {i}")
+                    time.sleep(2)  # Rate limiting
+                    return fit_data
+                else:
+                    print(f"Method {i} returned empty data")
+                    
+            except Exception as e:
+                print(f"Method {i} failed: {type(e).__name__}: {e}")
+                last_exception = e
+                continue
+        
+        # If all methods failed, raise the last exception
+        raise RuntimeError(f"All download methods failed. Last error: {last_exception}")
 
-# Example usage:
-# client = GarminClient()
-# activities = client.get_activities(0, 10)
-# fit_data = client.download_activity_fit(12345)
+    def get_activity_details(self, activity_id):
+        """Get detailed information about a specific activity"""
+        if not self.client:
+            self.authenticate()
+            
+        try:
+            activity_details = self.client.get_activity_by_id(activity_id)
+            time.sleep(2)  # Rate limiting
+            return activity_details
+        except Exception as e:
+            print(f"Failed to get activity details for {activity_id}: {e}")
+            return None
+
+# Example usage and testing function
+def test_download(activity_id):
+    """Test function to verify download functionality"""
+    client = GarminClient()
+    try:
+        fit_data = client.download_activity_fit(activity_id)
+        
+        # Verify the data looks like a FIT file
+        if fit_data and len(fit_data) > 14:
+            # FIT files start with specific header
+            header = fit_data[:14]
+            if b'.FIT' in header or header[8:12] == b'.FIT':
+                print("✅ Downloaded data appears to be a valid FIT file")
+                return fit_data
+            else:
+                print("⚠️ Downloaded data may not be a FIT file")
+                print(f"Header: {header}")
+                return fit_data
+        else:
+            print("❌ Downloaded data is empty or too small")
+            return None
+            
+    except Exception as e:
+        print(f"❌ Test failed: {e}")
+        return None
+
+if __name__ == "__main__":
+    # Test with a sample activity ID if provided
+    import sys
+    if len(sys.argv) > 1:
+        test_activity_id = sys.argv[1]
+        print(f"Testing download for activity ID: {test_activity_id}")
+        test_download(test_activity_id)
+    else:
+        print("Usage: python garmin.py <activity_id>")
+        print("This will test the download functionality with the provided activity ID")
\ No newline at end of file